From d89d3db1261d3effdb774e2901a508cd45b9a197 Mon Sep 17 00:00:00 2001 From: aap Date: Thu, 31 Dec 2020 16:14:51 +0100 Subject: [PATCH] fix UB --- src/weapons/Explosion.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/weapons/Explosion.cpp b/src/weapons/Explosion.cpp index 38ce6e53..74137dc0 100644 --- a/src/weapons/Explosion.cpp +++ b/src/weapons/Explosion.cpp @@ -121,7 +121,12 @@ CExplosion::AddExplosion(CEntity *explodingEntity, CEntity *culprit, eExplosionT #endif int n = 0; +#ifdef FIX_BUGS + while (n < ARRAY_SIZE(gaExplosion) && gaExplosion[n].m_nIteration != 0) +#else + // array overrun is UB while (gaExplosion[n].m_nIteration != 0 && n < ARRAY_SIZE(gaExplosion)) +#endif n++; if (n == ARRAY_SIZE(gaExplosion)) return false;