From e892f358e8d84177fee7d6ea53c2fde6d97b6925 Mon Sep 17 00:00:00 2001 From: Nicolas F Date: Tue, 10 Jul 2018 07:15:19 +0200 Subject: [PATCH] users: activation button improvements (#506) Now uses flask.flash to give the person who clicks it feedback when it's clicked, because caching may make things confusing. Also only activate a user if they're inactive, as again, caching can lead to staff pressing the button multiple times in a row, leading to unnecessary log messages. --- nyaa/views/users.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/nyaa/views/users.py b/nyaa/views/users.py index 6abca7d..775bf95 100644 --- a/nyaa/views/users.py +++ b/nyaa/views/users.py @@ -58,11 +58,12 @@ def view_user(user_name): db.session.add(adminlog) if admin_form.activate_user.data and not user.is_banned: - user.status = models.UserStatusType.ACTIVE - adminlog = models.AdminLog("[{}]({}) was manually activated" - .format(user_name, url), - admin_id=flask.g.user.id) - db.session.add(adminlog) + if user.status != models.UserStatusType.ACTIVE: + user.status = models.UserStatusType.ACTIVE + adminlog = models.AdminLog("[{}]({}) was manually activated" + .format(user_name, url), admin_id=flask.g.user.id) + db.session.add(adminlog) + flask.flash('{} was manually activated'.format(user_name), 'success') db.session.add(user) db.session.commit()